Conversation
hacktobeer
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralized DuckDB SQLite connection logic and implemented a validation-based retry mechanism for LLM-generated SQL queries.
Technical Details:
_duckdb_sqlite_connectioncontext manager insrc/lib/duckdb_utils.py. This centralizes the loading of the SQLite scanner extension, security configurations, and database attachment, ensuring connections are consistently closed.generate_sql_queryto include a retry loop (up to 3 attempts). The function now validates generated queries by executing them against the target database. If a query fails, the error message is passed back to the LLM to facilitate automated correction.strftime, case-insensitive text matching withLOWER(), and specific handling for different epoch precisions.require_accessdecorator inauthz.pyto provide separate sync and async wrappers. This ensures the access control logic executes correctly regardless of whether the decorated function is a coroutine.pytztopyproject.tomlandpoetry.lockto support timezone-aware date conversions within the generated SQL queries.generate_queryendpoint insrc/api/v1/files.pyto pass the file object into the generation logic for query validation.